jsrepo v3 #720
Merged
jsrepo v3 #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
seems pretty nice, I think we can go with it. The only problem is, with this approach, I still have to manage two different files for component data, which will easily go out of sync if I'm not careful (Information.js and jsrepo.config.ts) |
Contributor
Author
Ahh I didn't see this. We could also just delete this now :) Just need to move that info into the jsrepo.config before I do. |
Contributor
Author
|
It's also worth mentioning that it seems like a lot of the meta data from that file is being left out of the registry currently so I can make that work as well. |
Contributor
Author
|
Okay now everything will instead be based off of Information.js and you just need to make sure that stays up to date. It looks like it's missing a few components atm. |
Owner
|
I don't think it's missing anything, I keep that one updated with every addition/deletion, it should be the single source of truth for what's in the library |
Contributor
Author
|
It looks like all that's missing right now is rolling gallery |
Owner
|
Yeah no, that one was completely deleted from the library, should not exist anymore |
Contributor
Author
|
Oh perfect then :) |
Contributor
Author
|
@DavidHDev jsrepo v3 is now out I just updated the installation instructions so this should be good to go! |
Owner
|
Alright! Awesome, let's merge this and see if anything blows up! 😰 |
Contributor
Author
|
Just ping me if anything does I should be available |
Owner
|
well, something did blow up: |
Contributor
Author
|
Whoops! Let me take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you might like this one better, I think it strikes a good balance between minimizing the config needed and the magic while also maximizing the configurability.
This proposal rotates around a function in the config file called
defineComponent. This function takes in thetitle,category, anddescriptionand defines the files necessary for each variant.For example:
We define all our items with
defineComponentin theitemsarray and then we can build the registry with:jsrepo build # watch mode jsrepo build --watchWe use the
@jsrepo/shadcnpackage to adapt the jsrepo build output to something that the shadcn CLI can understand using the output exported from the package:We set
dirtopublic/rto tell jsrepo to output the registry underpublic/r.I also added 2 new commands to the
package.jsonthat will do the work of the other commands before:registry:build- Builds the registryregistry:dev- Builds the registry in watch modeUsers
shadcnCLI usersjsrepousersjsrepousers will have a few options for how to add components:TODO:
make-define-component-code.tsregistry.jsonjsreposection of the docs